feat(phaserx): allow running phaser in headless mode for unit testing in jest #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidkol
commented
Jul 27, 2022
davidkol
commented
- allow jest unit testing on phaser layer
- skip waiting for phaser textures when running in headless mode
- check if renderer exists before using it
alvrs
reviewed
Jul 27, 2022
alvrs
reviewed
Jul 27, 2022
packages/phaserx/src/defineScene.ts
Outdated
Comment on lines
22
to
23
| renderer?.pipelines?.add(HueTintAndOutlineFXPipeline.KEY, new HueTintAndOutlineFXPipeline(this.game)); | ||
| renderer?.pipelines?.add(MultiHueTintPipeline.KEY, new MultiHueTintPipeline(this.game)); |
There was a problem hiding this comment.
Do we need the first question mark? (Is renderer undefined in Headless mode or only pipelines?)
Suggested change
| renderer?.pipelines?.add(HueTintAndOutlineFXPipeline.KEY, new HueTintAndOutlineFXPipeline(this.game)); | |
| renderer?.pipelines?.add(MultiHueTintPipeline.KEY, new MultiHueTintPipeline(this.game)); | |
| renderer.pipelines?.add(HueTintAndOutlineFXPipeline.KEY, new HueTintAndOutlineFXPipeline(this.game)); | |
| renderer.pipelines?.add(MultiHueTintPipeline.KEY, new MultiHueTintPipeline(this.game)); |
There was a problem hiding this comment.
looks like we dont, renderer is defined, great catch!
There was a problem hiding this comment.
scratch that, it didnt save when i ran the tests with that change, renderer is NOT defined and does in fact need to be checked
There was a problem hiding this comment.
could also mock this function instead of checking for renderer
alvrs
reviewed
Jul 27, 2022
| @@ -87,7 +87,7 @@ export function createChunkedTilemap<TileKeys extends number, LayerKeys extends | |||
| ); | |||
|
|
|||
| if (layer.hasHueTintShader) { | |||
| layers[key].pipeline = (scene.game.renderer as Phaser.Renderer.WebGL.WebGLRenderer).pipelines.get( | |||
| layers[key].pipeline = (scene.game.renderer as Phaser.Renderer.WebGL.WebGLRenderer)?.pipelines?.get( | |||
There was a problem hiding this comment.
Same question here, is renderer undefined in Headless mode or just pipelines?
Suggested change
| layers[key].pipeline = (scene.game.renderer as Phaser.Renderer.WebGL.WebGLRenderer)?.pipelines?.get( | |
| layers[key].pipeline = (scene.game.renderer as Phaser.Renderer.WebGL.WebGLRenderer).pipelines?.get( |
alvrs
approved these changes
Jul 27, 2022
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
… in jest (latticexyz#112) * feat(phaserx): allow running phaser in headless mode for unit testing * fix(phaserx): clean up renderer undefined checks and headless equality check * refactor(phaserx): clean up renderer pipeline checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.