feat: general service improvements #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Oct 4, 2022
•
ghost
commented
- Clean up code around allowing sync from block via param
- Lookup snapshots by checksumming the address in RPC requests (avoid mismatch of lowercases)
- Move more params to flags for snapshot service for easier tweaks
- Rewrite server code to have more code reuse
ghost
force-pushed
the
authcall/general-service-improvements
branch
from
a5fef24
to
2f78cba
Compare
ghost
marked this pull request as ready for review
alvrs
approved these changes
Oct 5, 2022
LPSCRYPT
pushed a commit
to LPSCRYPT/esp
that referenced
this pull request
Jan 23, 2023
* feat: add param for which block to sync from * feat: lookup snapshots with checksum address of RPC request * feat: move constants to command flags * chore: rewrite grpc server code to reuse more code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.