Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): separate config from cli #600

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Apr 8, 2023

No description provided.

@dk1a dk1a requested review from alvrs and holic as code owners April 8, 2023 13:03
Comment on lines +5 to +6
import { loadStoreConfig, loadWorldConfig } from "@latticexyz/config";
import { MUDError } from "@latticexyz/config";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially wanted to put MUDError into utils package, but importing it doesn't work yet so left this for another PR

} from "./config/index.js";

export { storeConfig, mudConfig } from "./config/index.js";
export {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@holic holic merged commit cd224a5 into main Apr 9, 2023
@holic holic deleted the dk1a/config-cli-separation branch April 9, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants