feat(world): use ResourceId namespaceId for all methods acting on the namespace as a resource

[alvrs]

Fixes #1552
Followup to #1544

All methods acting on namespaces as resources (ownership and balances of namespaces) now use ResourceId namespaceId instead of bytes14 namespace for clarity and improved compile time type safety (no more implicit casting)

• WorldRegistrationSystem now uses ResourceId namespaceId instead of bytes14 namespace for registerNamespace
• BalanceTransferSystem now uses ResourceId namespaceId instead of bytes14 namespace for all methods
• AccessManagementSystem now uses ResourceId namespaceId instead of bytes14 namespace for transferOwnership and internal ownership checks

[changeset-bot]

🦋 Changeset detected

Latest commit: 7309f54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@latticexyz/world	Major
@latticexyz/store	Major
@latticexyz/cli	Major
@latticexyz/dev-tools	Major
@latticexyz/store-sync	Major
@latticexyz/react	Major
@latticexyz/store-indexer	Major
@latticexyz/abi-ts	Major
@latticexyz/block-logs-stream	Major
@latticexyz/common	Major
@latticexyz/config	Major
create-mud	Major
@latticexyz/ecs-browser	Major
@latticexyz/faucet	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/protocol-parser	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[holic]

I think this is leftover from our "file" analogy, which I think we've moved on from?

We should agree on a stringified version of these resource IDs, and my vote would be something like

type_namespace_name
type:namespace:name

(Stripe uses e.g. acct_1234 and ch_1234)

[alvrs]

don't have a strong opinion on the separator string, _ was just a bit confusing in ROOT_NAMESPACE_ROOT_NAME. : works for me!

[alvrs]

how about namespace:name:type? (to make the order match the encoding)

[holic]

I would still argue for the more human readable form here, and asked in the other PR about moving the order for our helpers

[alvrs]

from discord for future reference

I’m fine sticking with encoding order for resources
not my favorite but I’m optimizing for consistency and gas

[holic]

Suggested change

import { console } from "forge-std/console.sol";

[holic]

We sorta talked about this in the other PR but I wonder if there's any value to having a NamespaceId wrapper rather than full resource ID where we mask/shift/slice the namespace from it.

[alvrs]

would prefer one user type for all of these because i want to add checks like namespaceId.isType(RESOURCE_NAMESPACE) in the next PR - if namespaceId uses a different user type, we'd have to duplicate the ResourceId library for it. (We can't trust the id provided as argument to actually be a valid namespace id, even if it would be of type NamespaceId, because anyone can just wrap whatever with NamespaceId)

[holic]

oh right, I forgot we have a namespace type, that makes sense