Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): link and deploy public libraries #1910

Merged
merged 32 commits into from Mar 11, 2024
Merged

feat(cli): link and deploy public libraries #1910

merged 32 commits into from Mar 11, 2024

Conversation

dk1a
Copy link
Member

@dk1a dk1a commented Nov 11, 2023

fixes #1911

Copy link

changeset-bot bot commented Nov 11, 2023

🦋 Changeset detected

Latest commit: bcc2f28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@latticexyz/cli Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world-modules Major
@latticexyz/world Major
mock-game-contracts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

yonadaaa
yonadaaa previously approved these changes Mar 11, 2024
@@ -9,18 +9,21 @@ export const defaultModuleContracts = [
name: "KeysWithValueModule",
abi: KeysWithValueModuleData.abi as Abi,
bytecode: KeysWithValueModuleData.bytecode.object as Hex,
placeholders: [], // TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this TODO? I can see us revisiting this and not knowing what we need "to do"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will clarify! this isn't used/needed right now but would need to be filled in if these modules ever start using public libs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went ahead and just moved out the placeholder logic so I could reuse it here: 4fea2b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support public libraries
3 participants