Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store,world): remove unused imports [N-05] #2028

Merged
merged 6 commits into from Jan 3, 2024

Conversation

yonadaaa
Copy link
Contributor

@yonadaaa yonadaaa commented Dec 6, 2023

Removes unused imports as reported by the audit, expect for

Import DecodeSlice of Slice.sol

removing this one causes issues with files that use SliceLib.

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: ec10366

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/store Patch
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonadaaa
Copy link
Contributor Author

yonadaaa commented Jan 3, 2024

@alvrs removing the DecodeSlice import from Slice.sol causes the following compiler error so I have kept it in:

Member "decodeArray_bytes21" not found or not visible after argument-dependent lookup in Slice.
@latticexyz/store:build:    --> src/codegen/tables/StoreHooks.sol:106:13:
@latticexyz/store:build:     |
@latticexyz/store:build: 106 |     return (SliceLib.getSubslice(_blob, 0, _blob.length).decodeArray_bytes21());
@latticexyz/store:build:     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alvrs alvrs merged commit e481717 into main Jan 3, 2024
11 checks passed
@alvrs alvrs deleted the yonadaaa/remove-unused-imports branch January 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants