fix(world): prevent initialising the world multiple times [L-05] #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 78336aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
reviewed
Jan 22, 2024
packages/world/src/World.sol
Outdated
| revert World_AlreadyInitialized(); | ||
| } | ||
|
|
||
| WorldInitialized.set(true); |
There was a problem hiding this comment.
What if we store the core module's address here? Almost the same cost (since it's one storage write) but might be interesting to know which core module was used to init the world
There was a problem hiding this comment.
Sure, that seems like a reasonable thing to keep around. It kind of "enshrines" the core module differently to the other modules, but we are already writing to storage for it.
alvrs
reviewed
Jan 22, 2024
alvrs
reviewed
Jan 22, 2024
Co-authored-by: alvarius <alvarius@lattice.xyz>
Co-authored-by: alvarius <alvarius@lattice.xyz>
yonadaaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the world from being initialised multiple times. Pulled out from #2168