-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade vitest to ^1.0.4 #2190
Conversation
|
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm we should figure out why this trailing empty line differs as it prob points to an inconsistent linter or formatter
did you edit these files manually or use something like pnpm upgrade
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually 😬 couldn't figure out how to specify the version with pnpm upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually do something like pnpm add package@version
to install a particular version (it'll overwrite whatever version exists in package.json)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enabled Insert Final Newline in my VSCode and the formatting is correct now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the toEqualTypeOf
types are more strict now, but maybe there is some way we can use it. Failing test run: https://github.com/latticexyz/mud/actions/runs/7654925617/job/20859876029?pr=2190#step:6:1856
Closing in favour of #2193 |
No description provided.