Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade vitest to ^1.0.4 #2190

Closed
wants to merge 7 commits into from
Closed

Conversation

yonadaaa
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: 2c3c4ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm we should figure out why this trailing empty line differs as it prob points to an inconsistent linter or formatter

did you edit these files manually or use something like pnpm upgrade?

Copy link
Contributor Author

@yonadaaa yonadaaa Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually 😬 couldn't figure out how to specify the version with pnpm upgrade

Copy link
Member

@holic holic Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do something like pnpm add package@version to install a particular version (it'll overwrite whatever version exists in package.json)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled Insert Final Newline in my VSCode and the formatting is correct now

Copy link
Contributor Author

@yonadaaa yonadaaa Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the toEqualTypeOf types are more strict now, but maybe there is some way we can use it. Failing test run: https://github.com/latticexyz/mud/actions/runs/7654925617/job/20859876029?pr=2190#step:6:1856

@yonadaaa yonadaaa changed the title chore: upgrade vitest chore: upgrade vitest to ^1.0.4 Jan 25, 2024
@yonadaaa
Copy link
Contributor Author

Closing in favour of #2193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants