Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): rename StoreCore.registerCoreTables to registerInternalTables #2225

Merged
merged 6 commits into from Feb 2, 2024

Conversation

holic
Copy link
Member

@holic holic commented Feb 1, 2024

to clarify and clear the "core" term for other uses

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: e58b76f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/store Major
@latticexyz/world Major
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/react Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/world-modules Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic force-pushed the holic/register-internal-tables branch from 50a7ace to dbf9a37 Compare February 1, 2024 16:09
yonadaaa
yonadaaa previously approved these changes Feb 1, 2024
Copy link
Contributor

@yonadaaa yonadaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot more, "Core Module" made it seem like some overly important piece

_registerSystem(balanceTransferSystem, BALANCE_TRANSFER_SYSTEM_ID);
_registerSystem(batchCallSystem, BATCH_CALL_SYSTEM_ID);
_registerSystem(coreRegistrationSystem, CORE_REGISTRATION_SYSTEM_ID);
function _registerInternalSystems() internal {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a little bit off to call these "internal systems" - with that name I'd think of internal functions, ie something that's not externally accessible, but these systems become part of the "core" API 🙈

Copy link
Member Author

@holic holic Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're in the CoreModule (soon InitModule), maybe we can just name these _registerTables, _registerSystems, and _registerSystem because that's what installing the module does? _registerFunctionSelectors is already named as such.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went ahead and did this in e58b76f

@holic holic requested review from alvrs and yonadaaa February 1, 2024 20:06
@holic holic changed the title feat(store,world): rename registerCore* methods to registerInternal* feat(store): rename registerCoreTables methods to registerInternalTables Feb 1, 2024
@holic holic changed the title feat(store): rename registerCoreTables methods to registerInternalTables feat(store): rename registerCoreTables to registerInternalTables Feb 1, 2024
@holic holic changed the title feat(store): rename registerCoreTables to registerInternalTables feat(store): rename StoreCore.registerCoreTables to registerInternalTables Feb 1, 2024
@holic holic merged commit 5c52bee into main Feb 2, 2024
14 checks passed
@holic holic deleted the holic/register-internal-tables branch February 2, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants