Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move table ID and field layout constants into table library #2327

Merged
merged 5 commits into from Feb 28, 2024

Conversation

holic
Copy link
Member

@holic holic commented Feb 27, 2024

fixes #2166

no gas changes but feels cleaner

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: e450107

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
create-mud Major
@latticexyz/cli Major
@latticexyz/common Major
@latticexyz/store Major
@latticexyz/world Major
@latticexyz/world-modules Major
@latticexyz/block-logs-stream Major
@latticexyz/config Major
@latticexyz/dev-tools Major
@latticexyz/faucet Major
@latticexyz/protocol-parser Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/react Major
@latticexyz/abi-ts Major
@latticexyz/ecs-browser Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

yonadaaa
yonadaaa previously approved these changes Feb 28, 2024
Copy link
Contributor

@yonadaaa yonadaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! interested to see this with the hardcoded schema too

@holic holic merged commit 4423604 into main Feb 28, 2024
11 checks passed
@holic holic deleted the holic/in-lib-table-id branch February 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider moving codegen table ID constant inside library
2 participants