Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(world-modules): token modules always register namespace #2352

Merged
merged 3 commits into from Mar 1, 2024

Conversation

yonadaaa
Copy link
Contributor

@yonadaaa yonadaaa commented Feb 29, 2024

Updates the ERC20 and ERC721 implementations to always register the token namespace, instead of checking if it has already been registered. This prevents issues with registering the namespace beforehand, namely that only the owner of a system can create a puppet for it.

Fixes #2354

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: f6650e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/world-modules Patch
@latticexyz/cli Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yonadaaa yonadaaa changed the title fix(world-modules): tokens always register namespace fix(world-modules): token modules always register namespace Feb 29, 2024
Co-authored-by: Kevin Ingersoll <kingersoll@gmail.com>
@yonadaaa yonadaaa merged commit 4be22ba into main Mar 1, 2024
14 checks passed
@yonadaaa yonadaaa deleted the yonadaaa/token-register-namespace branch March 1, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token modules should always register namespace
3 participants