Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): run contracts test #2377

Merged
merged 4 commits into from Mar 11, 2024
Merged

test(e2e): run contracts test #2377

merged 4 commits into from Mar 11, 2024

Conversation

yonadaaa
Copy link
Contributor

@yonadaaa yonadaaa commented Mar 6, 2024

We missed a failing contract test (testMemoryCorruption, now fixed in #2378) because only the e2e sync tests were running

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 4cdbbae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@holic holic changed the title chore(e2e): run contracts test test(e2e): run contracts test Mar 11, 2024
Co-authored-by: Kevin Ingersoll <kingersoll@gmail.com>

- name: Run tests
working-directory: ./e2e
run: pnpm run test:ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should combine this with the above so we don't run sync tests twice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@holic holic merged commit f90e823 into main Mar 11, 2024
11 checks passed
@holic holic deleted the yonadaaa/e2e-run-contracts branch March 11, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants