Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(world-modules): call with signature supports ERC1271 #2559

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

yonadaaa
Copy link
Contributor

fixes #2552

We now emit a generic InvalidSignature error with no arguments, because we are agnostic about signature schemes and the signer (if any) derived by signing contracts.

Copy link

changeset-bot bot commented Mar 27, 2024

⚠️ No Changeset found

Latest commit: b70af5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yonadaaa
Copy link
Contributor Author

Do we want to add a test that sets up a smart contract and registers a delegation for it? or do we trust the OZ signature checker

@yonadaaa yonadaaa changed the title feat(world-modules): register with delegation supports ERC1271 feat(world-modules): call with signature supports ERC1271 Apr 5, 2024
@yonadaaa yonadaaa merged commit 82ada7a into main Apr 25, 2024
12 checks passed
@yonadaaa yonadaaa deleted the yonadaaa/register-delegation-eip1271 branch April 25, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

callWithDelegation should support ERC1271
2 participants