-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NA values with boolean column (fix #100, fix #102, fix #103) #104
Support NA values with boolean column (fix #100, fix #102, fix #103) #104
Conversation
fc3ab3e
to
9d680a2
Compare
9d680a2
to
23a6df9
Compare
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 91.99% 92.39% +0.39%
==========================================
Files 14 14
Lines 1062 1104 +42
==========================================
+ Hits 977 1020 +43
+ Misses 85 84 -1
Continue to review full report at Codecov.
|
12b5735
to
d13c8d3
Compare
d13c8d3
to
16c9e12
Compare
self.assertEqual(rows, [ | ||
(True, False), | ||
(False, None), | ||
(None, None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice tests ! I understand that since you dont provide a dtype for the boolean column when calling read_csv. Pandas cast it either to boolean if there are no missing values or object if there are some ?
That would explain why it's a None and not a na.
Thanks a lot for the prompt PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote how to customize dtypes and converters in README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PyAthena/pyathena/converter.py
Line 145 in 6276338
class DefaultPandasTypeConverter(Converter): |
By default this class is used.
fcb9bae
to
fdaadde
Compare
fdaadde
to
03805e5
Compare
No description provided.