Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Fixed not finding JDBC driver class when creating multiple connections #8

Merged
merged 4 commits into from
Mar 20, 2017

Conversation

laughingman7743
Copy link
Owner

Sometimes JVM crashes with multithreaded test case. The cause is that JPype does not support multithreading.
jpype-project/jpype#211

@codecov-io
Copy link

codecov-io commented Mar 19, 2017

Codecov Report

Merging #8 into master will increase coverage by 0.39%.
The diff coverage is 93.75%.

@@            Coverage Diff            @@
##           master      #8      +/-   ##
=========================================
+ Coverage   87.31%   87.7%   +0.39%     
=========================================
  Files           7       7              
  Lines         465     480      +15     
=========================================
+ Hits          406     421      +15     
  Misses         59      59
Impacted Files Coverage Δ
pyathenajdbc/util.py 84.84% <100%> (+4.84%) ⬆️
pyathenajdbc/connection.py 80.76% <87.5%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50cd80...b4962c5. Read the comment docs.

@laughingman7743
Copy link
Owner Author

It seems that the JVM crashes no longer because it synchronized the function that starts the JVM.

@tewfik-ghariani
Copy link

That certainly solves the issue,
Thank you so much 👍

@laughingman7743 laughingman7743 merged commit 4762019 into master Mar 20, 2017
@laughingman7743 laughingman7743 deleted the fix_multiple_connection_issue branch March 20, 2017 04:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants