Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvements #46

Merged
merged 5 commits into from May 2, 2011
Merged

Several improvements #46

merged 5 commits into from May 2, 2011

Conversation

RomainMuller
Copy link

  • Editable toolbar
  • Hidden SVN controls when no SVN remote
  • Escaped HTML in commit comment.

@RomainMuller
Hide SVN controls if repository doesn't have a SVN remote instead of …
e3559c9 
…only disabling them.
@RomainMuller
Make the toolbar editable.
a775582
@RomainMuller
Tidy up the commit message to ensure it won't break the diff view.
3f416bb 
Renamed the GLFileView's +parseHTML into something more meaningful regarding what it actually does.

Also, the method might need to be moved to somewhere else...
@RomainMuller
Rename cleanupHTML: to escapeHTML:
7d82aa0
@RomainMuller
Use setHidden: instead of setTrasnparent:
e05be3b
laullon added a commit that referenced this pull request May 2, 2011
@laullon
Merge pull request #46 from RomainMuller/pull_request.
940e09d 
Several improvements
* Editable toolbar
* Hidden SVN controls when no SVN remote
* Escaped HTML in commit comment.
@laullon laullon merged commit 940e09d into laullon:master May 2, 2011
@laullon
Copy link
Owner

laullon commented May 2, 2011

Thanks... good work.

jspiro pushed a commit to jspiro/gitx that referenced this pull request Nov 26, 2021
@ssp
Fix display of renames (laullon#46)
2b06aa6 
The option to show file moves in a single line
rather than a separate remove and add is not one
to set when creating the diff. It has to be used
to manipulate that diff in an additional step.

As all the parameters used here as NSString /
NSNumber-typed the compiler couldn’t detect
the option being passed to the wrong method :/

Also adapted the JS to display the file moving
again.

This behaviour was introduced in 7af30a7. It
should fix the issue described in laullon#46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RomainMuller @laullon