Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the dependent version of more_itertools to higher than 7.1.0 #251

Merged
merged 1 commit into from Jun 29, 2021
Merged

fix the dependent version of more_itertools to higher than 7.1.0 #251

merged 1 commit into from Jun 29, 2021

Conversation

Songmu
Copy link
Contributor

@Songmu Songmu commented Jun 28, 2021

I got the following error on GitHub Actions when executing launchable cli.

ImportError: cannot import name 'ichunked' from 'more_itertools' (/usr/lib/python3/dist-packages/more_itertools/init.py)
-- https://github.com/x-motemen/ghq/runs/2932241995?check_suite_focus=true

I upgraded more_itertools and resolved the problem.

I checked and found that the ichunked was introduced in version 7.1.0, so we need to specify a dependent version in higher versions.

ref. https://more-itertools.readthedocs.io/en/stable/versions.html#id13

@awilkes awilkes requested a review from ninjinkun June 28, 2021 15:07
@awilkes
Copy link
Contributor

awilkes commented Jun 28, 2021

Thanks for your contribution, @Songmu! We will review this.

@ninjinkun
Copy link
Contributor

@Songmu Looks good! Thanks for your contribution.

@ninjinkun ninjinkun merged commit 6c69b95 into launchableinc:main Jun 29, 2021
@ninjinkun
Copy link
Contributor

ninjinkun commented Jun 29, 2021

Released v1.22.4 including this.

@Songmu Songmu deleted the fix-dependency branch June 29, 2021 08:24
@Songmu
Copy link
Contributor Author

Songmu commented Jun 29, 2021

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants