add nullability info to Describe, fix bad "unknown type" errors in query!()
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/describe-nullability
branch
3 times, most recently
from
35e5a6b
to
b14c45b
Compare
abonander
force-pushed
the
ab/describe-nullability
branch
3 times, most recently
from
ed13e07
to
93f4302
Compare
abonander
changed the title
query!()
abonander
force-pushed
the
ab/describe-nullability
branch
2 times, most recently
from
b57992c
to
7d234e4
Compare
This was referenced Feb 9, 2020
abonander
force-pushed
the
ab/describe-nullability
branch
2 times, most recently
from
4feb50e
to
f762013
Compare
* this breaks a lot internally as-is * mysql needs a restructure
thedodd
reviewed
Feb 21, 2020
thedodd
reviewed
Feb 21, 2020
| type_, | ||
| i + 1, | ||
| ) | ||
| .into() |
There was a problem hiding this comment.
Nice! This will probably help a lot of folks. Easy to forget to add feature flags.
thedodd
approved these changes
Feb 21, 2020
… type; remove Cursor::first
* Allow `conn.fetch(" ... ")` to be called where `conn` is an owned Connection
* Executor::fetch -> RefExecutor::fetch_by_ref
* Executor::fetch_by_ref -> Executor::fetch
* Move `Connection::describe` to `Executor::describe`
* `Transaction` is no longer a `Connection`
* `Connection` has `Executor` as a super-trait again which greatly simplifies bounds
…&Pool to continue working in 0.3
implement nullability check for Postgres as a query on pg_attribute implement type name fetching for Postgres as part of `describe()` add nullability for describe() to MySQL improve errors with unknown result column type IDs in `query!()` run cargo fmt and fix warnings improve error when feature gates for chrono/uuid types is not turned on workflows/rust: add step to UI-test missing optional features improve error for unsupported/feature-gated input parameter types fix `PgConnection::get_type_names()` for empty type IDs list fix `tests::mysql::test_describe()` on MariaDB 10.4 copy-edit unsupported/feature-gated type errors in `query!()` Postgres: fix SQL type of string array Co-Authored-By: Anthony Dodd <Dodd.AnthonyJosiah@gmail.com>
abonander
force-pushed
the
ab/describe-nullability
branch
from
3ac81ab
to
30d45e8
Compare
|
Rebased onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #88 that we can push in a patch release:
Describedescribe::Columnis marked#[non_exhaustive]the new field is a backwards-compatible addition.pg_attributeto get non-null columns in Postgres andpg_typeto get type namesWhile I was at it I fixed the "unknown type" error being useless for
query!()params and columns since for Postgres it needed to fetch the type info anyway.Closes #107
Closes #17