sqlite: use Arc<> around StatementHandle instead of Copying it #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guarantees that StatementHandle is never used after calling `sqlite3_finalize`. Now `sqlite3_finalize` is only called when StatementHandle is dropped.
Otherwise some tests fail to close connection.
|
This is an attempt to fix persistent segfaults in |
madadam
reviewed
Jul 7, 2021
Comment on lines
+38
to
+43
| let resp = match status { | ||
| SQLITE_ROW => Ok(Either::Right(())), | ||
| SQLITE_DONE => Ok(Either::Left(statement.changes())), | ||
| _ => Err(statement.last_error().into()), | ||
| }; | ||
| resp |
There was a problem hiding this comment.
Suggested change
| let resp = match status { | |
| SQLITE_ROW => Ok(Either::Right(())), | |
| SQLITE_DONE => Ok(Either::Left(statement.changes())), | |
| _ => Err(statement.last_error().into()), | |
| }; | |
| resp | |
| match status { | |
| SQLITE_ROW => Ok(Either::Right(())), | |
| SQLITE_DONE => Ok(Either::Left(statement.changes())), | |
| _ => Err(statement.last_error().into()), | |
| } |
| resp | ||
| } else { | ||
| // Statement is already finalized. | ||
| Err(Error::WorkerCrashed) |
There was a problem hiding this comment.
Strictly speaking, the worker didn't actually crash here. I'd consider a different error variant, maybe even a new one if none of the existing fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.