Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From for AnyConnection #1652

Merged
merged 3 commits into from Feb 17, 2022
Merged

Implement From for AnyConnection #1652

merged 3 commits into from Feb 17, 2022

Conversation

genusistimelord
Copy link
Contributor

This should implement From for AnyConnection so that other connection types can be converted to AnyConnection for libraries that need to support multiple Database's.

@genusistimelord
Copy link
Contributor Author

I have implemented From as suggested by @05storm26

genusistimelord added a commit to AscendingCreations/AxumSessionAuth that referenced this pull request Jan 24, 2022
…aunchbadge/sqlx#1652  if this is not implemented then I will make a implementation lib that replaces their Any with my own version
@genusistimelord
Copy link
Contributor Author

@abonander Anything I am missing or need to do to get this implemented?

@genusistimelord
Copy link
Contributor Author

can someone please approve the work flow? Thank you.

@abonander
Copy link
Collaborator

@genusistimelord looks like cargo fmt needs to be run

@genusistimelord
Copy link
Contributor Author

@abonander I ran cargo fmt.

@abonander abonander merged commit 183e620 into launchbadge:master Feb 17, 2022
genusistimelord added a commit to AscendingCreations/AxumSessionAuth that referenced this pull request Feb 24, 2022
* Changed API to support SqlxSessions multi supported Pool and Connection

* Update readme to include new changes and Changed version to 0.2

* make sqlx use current test branch

* Readme with new Changes from AxumSqlxSessions. Publish is waiting on launchbadge/sqlx#1652  if this is not implemented then I will make a implementation lib that replaces their Any with my own version

* Fixed missing Some() in readme

* Updated SQLx to FromForAny

* add any feature to sqlx

* Added features with default postgres for sqlx

* Rename with AxumSession usage instead of the sqlx version

* Rename and a few changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants