SQLite unlock notification #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madadam
force-pushed
the
sqlite-unlock-notify
branch
from
e1d6fd2
to
56262e2
Compare
madadam
force-pushed
the
sqlite-unlock-notify
branch
from
56262e2
to
1406418
Compare
|
If this lands, I'd be great to include in a point release on top of |
madadam
added a commit
to madadam/ouisync
that referenced
this pull request
Jan 31, 2022
Temporary use a fork of sqlx until the necessary changes (launchbadge/sqlx#1658) are merged upstream.
madadam
added a commit
to equalitie/ouisync
that referenced
this pull request
Feb 1, 2022
Temporary use a fork of sqlx until the necessary changes (launchbadge/sqlx#1658) are merged upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement unlock notification to avoid
SQLITE_LOCKED("database table is locked") errors when running concurrent queries. The implementation is basically rustified version of the example from the official sqlite docs on https://www.sqlite.org/unlock_notify.html.Closes #1649