Set whoami default-features to false #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not look like the CI failures are due to the changes in this PR. |
|
@thedodd current development is on the |
|
Base changed to |
thedodd
force-pushed
the
patch-1
branch
2 times, most recently
from
9feec26
to
a5dbecf
Compare
Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps.
thedodd
commented
Feb 11, 2023
| dependencies = [ | ||
| "wasm-bindgen", | ||
| "web-sys", | ||
| ] |
|
@abonander this should be ready to rock now. |
grgi
pushed a commit
to FAccTs/sqlx
that referenced
this pull request
Feb 14, 2023
* Fixed typo. (launchbadge#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
abonander
pushed a commit
that referenced
this pull request
Feb 18, 2023
* Fixed typo. (#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
abonander
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Fixed typo. (#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
Aandreba
pushed a commit
to Aandreba/sqlx
that referenced
this pull request
Mar 31, 2023
* Fixed typo. (launchbadge#2156) * Set whoami default-features to false Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps. --------- Co-authored-by: Chris Foster <cdbfoster@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, whoami pulls in web-sys, wasm-bindgen and a BUNCH of additional dependencies. This is really unnecessary, and if someone has an actual use case where they are attempting to connect to postgres from a browser, well ... they've probably already been pwned by now. If it is deemed necessary, then add an additional activation feature for that specific slew of deps.