add args to query builder (#2494) #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abonander feedback appreciated |
abonander
requested changes
Jun 12, 2023
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
cemoktra
force-pushed
the
query-builder-with-args
branch
from
84c2be4
to
a283d86
Compare
abonander
reviewed
Jun 30, 2023
| .build(); | ||
|
|
||
| let mut qb: QueryBuilder<'_, Postgres> = | ||
| QueryBuilder::new_with(query.sql(), query.take_arguments()); |
There was a problem hiding this comment.
This test isn't actually running because sqlx-core doesn't have a postgres feature anymore.
I'll have to migrate this to be an integration test or something.
There was a problem hiding this comment.
Okay, is this a blocker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #2494
Allow to keep existing args when creating a query builder