Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all statements are dropped before closing sqlite connection #281

Merged
merged 1 commit into from Apr 27, 2020

Conversation

hasali19
Copy link
Contributor

Fixes #272

@mehcode
Copy link
Member

mehcode commented Apr 27, 2020

Thanks for the fix. Error looks like a spurious ui test failure.

cc @abonander

@mehcode mehcode merged commit 3e2ed00 into launchbadge:master Apr 27, 2020
@sgg
Copy link
Contributor

sgg commented Apr 29, 2020

FYI when I was working on the realworld example I was running into an issue where tables would end up locked if a transaction exited prematurely (e.g. due to a query failing).

This change seems to have fixed that issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLite backend does not close database
3 participants