Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hlint parse error on "pattern", rerun hlint --default. #46

Merged

Conversation

philderbeast
Copy link
Contributor

@philderbeast philderbeast commented Nov 2, 2022

HLint enables extensions but for the Operators module this is a problem for "pattern". I chose to disable pattern synonyms for this module but we could have renamed the pattern binding instead. With the parse error avoided, hlint finds more suggestions for us.

@keelerm84
Copy link
Member

Thanks again @philderbeast

I appreciate all these contributions. Do you plan on providing more PRs over the next couple of days or would you rather I cut a release with the current work first?

@keelerm84 keelerm84 merged commit 992e7c9 into launchdarkly:main Nov 2, 2022
@philderbeast
Copy link
Contributor Author

@keelerm84 I'd like a release with the cabal file addition (#44) right away if you can do that.

@keelerm84
Copy link
Member

Sounds good. I'm going to work on cutting a release for you today then. :D

@keelerm84
Copy link
Member

Hey @philderbeast sorry for the delay. There were a few things conspiring together to undermine my last comment. 😆 But I did finally get the 3.0.3 release out so you should be good to go. Thanks for your patience!

@philderbeast
Copy link
Contributor Author

Thanks for making a release @keelerm84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants