Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Drop explicit dependency on vector #69

Merged

Commits on Jan 30, 2024

  1. Drop explicit dependency on vector

    I wanted compatibility with vector-0.13. To check whether any of the vector-0.13
    changes were breaking, I reviewed where the existing code uses Data.Vector, and
    the answer is almost nowhere, and all existing use cases can be replaced with
    typeclass methods that don't require explicitly importing the module. As such,
    we can get away without an explicit direct dependency on vector, which should
    lighten the maintenance burden of getting the version bounds correct.
    
    Strictly speaking it is possible to imagine a future vector upgrade breaking
    this package, so we do lose something by dropping the version bounds entirely.
    But since the functionality we use from the module is so basic, it's a little
    hard to imagine that happening in practice.
    
    In addition, it's possible that switching from monomorphic functions to
    typeclass methods could have performance implications, but I don't think this
    code is particularly perf-sensitive, and anyway inlining may yet be enough to
    save us.
    bmillwood committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1945632 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Switch to using GHC.Exts for IsList

    This is where it was prior to base-4.17.0.0 (and can still be found
    now), so this helps us to retain compatibility with older base versions.
    bmillwood committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a2fe5c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    703a4bb View commit details
    Browse the repository at this point in the history
  3. Lint fix

    keelerm84 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f253b25 View commit details
    Browse the repository at this point in the history