Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Package.swift swift-tools-version 5.2 #234

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Update Package.swift swift-tools-version 5.2 #234

merged 2 commits into from
Jun 17, 2021

Conversation

escakot
Copy link
Contributor

@escakot escakot commented Jan 13, 2021 •
edited
Loading

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions (Using the build commands in config.yml)

Related issues
#233

Describe the solution you've provided
I've updated swift-tools-version to 5.2

Describe alternatives you've considered
N/A

Additional context
No updates required for swift-eventsource since it doesn't have dependencies.

@bwoskow-ld
Copy link
Member

Hi @escakot,

Thank you for submitting a pull request to fix #233! At first glance the changes look reasonable. As @gwhelanLD mentioned a few days ago, we'll do some verification on our side and will get back to you.

Thanks,
@bwoskow-ld

Filed internally as 98439.

@escakot
Copy link
Contributor Author

escakot commented Jan 14, 2021

Hi @bwoskow-ld,

For sure. Appreciate you guys for taking the time to test it out.

Thanks,
@escakot

@kreeger
Copy link

kreeger commented Jun 8, 2021 •
edited
Loading

Hey, what's the status on this? If it's been forgotten, I'd like to give it a friendly bump. If it helps, I've got an updated copy of this change, but sitting on top the latest of the v5 branch, in our fork of this project.

@bwoskow-ld
Copy link
Member

Hi @kreeger ,

This issue hasn't been forgotten, but thanks for the friendly bump. Apologies for not getting to it yet.

@gwhelanLD gwhelanLD self-requested a review June 17, 2021 22:56
@gwhelanLD gwhelanLD merged commit 3da096b into launchdarkly:v5 Jun 17, 2021
@gwhelanLD gwhelanLD mentioned this pull request Jun 17, 2021
Merged
gwhelanLD added a commit that referenced this pull request Jun 18, 2021
@gwhelanLD
Prepare 5.4.2 release (#248)
6813c0e 
## [5.4.2] - 2021-06-17
### Fixed
- Update `Package.swift` to use SwiftPM tools version 5.2. This prevents test dependencies from being included transitively. (Thanks, [@escakot](#234)!)
- Update `Quick` test dependency to 3.1.2 to avoid build warnings and adopt security fixes. ([#243](#243))
- Use `AnyObject` over `class` in protocol inheritance to avoid compiler warnings. ([#247](#247))
- Improve CI to test against multiple supported Xcode and Swift language versions.
- Restored test suite compatibility with Xcode 11.4 and Swift 5.2.
@gwhelanLD
Copy link
Contributor

Thanks for the contribution! It's been included in the 5.4.2 release.

Thanks,
@gwhelanLD

tanderson-ld pushed a commit that referenced this pull request Aug 2, 2023
@keelerm84
chore: Bump event source to 3.1.1 (#234)
e0bffba 
This doesn't actually change any behavior because we override the
default retry behavior, and that is all that changed since 3.1.0.
However, we do not want the SDK to drift too far from the eventsource
implementation, so I try to update it each time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwhelanLD gwhelanLD gwhelanLD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@escakot @bwoskow-ld @kreeger @gwhelanLD