Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Maven artifact has transitive dependencies on shadowed jar's #122

Closed
mrusinak opened this issue Mar 13, 2018 · 4 comments
Closed

Maven artifact has transitive dependencies on shadowed jar's #122

mrusinak opened this issue Mar 13, 2018 · 4 comments

Comments

@mrusinak
Copy link

mrusinak commented Mar 13, 2018

The POM file for com.launchdarkly:launchdarkly-client:3.0.2 has required dependencies on all the jars it shadows, which causes them to be included in the classpath of the project.

Not only does this seem to defeat the purpose of shadowing in the first place, but also winds up causing dependency issues with spring-data-redis 1.7.X (since it is compiled against Jedis 2.8.X and is binary incompatible with 2.9.X).

@eli-darkly
Copy link
Contributor

Thanks for letting us know. Yes, we'd better fix that.

@eli-darkly
Copy link
Contributor

I've looked into this, but the problem I'm still running into is that (as I understand it) while the Shadow plugin provides a task for publishing a jar with shaded classes, it doesn't seem to support publishing the complete set of jars with Javadoc etc. included. The online discussions of this I've seen have not suggested a clear workaround, so if anyone out there has made this work before, I'd be very happy to hear about it.

@eli-darkly
Copy link
Contributor

After a great deal of investigation, I think I finally understand what we're doing wrong. I was able to get a different Java project to build and publish correctly using Shadow, omitting the shaded dependencies from the POM. I will try to implement the same process for the Java SDK as soon as possible.

@eli-darkly
Copy link
Contributor

OK - very sorry this took so long to fix, but it should now be corrected as of the 4.4.1 release.

bwoskow-ld pushed a commit that referenced this issue May 1, 2019
Removed .fossa.yml, removed fossa job from circleci, removed fossa ba…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants