Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

RedisFeatureStore(RedisFeatureStoreBuilder(uri))always uses the default database index #106

Closed
ashanbrown opened this issue Nov 17, 2017 · 1 comment
Closed

RedisFeatureStore(RedisFeatureStoreBuilder(uri))always uses the default database index #106

ashanbrown opened this issue Nov 17, 2017 · 1 comment

Comments

@ashanbrown
Copy link
Contributor

This is because the database constructor used at:

https://github.com/launchdarkly/java-client/blob/4134349d06dc686d65234ca374fda9c55c887c54/src/main/java/com/launchdarkly/client/RedisFeatureStore.java#L118

uses a JedisPool constructor that uses the default db:

https://github.com/xetorthio/jedis/blob/1f1e23b26a4aa244ebfdbcbcdf489b630c841884/src/main/java/redis/clients/jedis/JedisPool.java#L93:62
@ashanbrown
Copy link
Contributor Author

False alarm

eli-darkly added a commit that referenced this issue Dec 13, 2018
@eli-darkly
Merge pull request #106 from launchdarkly/eb/feature-store-support
7203861 
add feature store support classes and use them in Redis
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ashanbrown