Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Consider using Murmur3 instead of SHA in VariationOrRollout #120

Closed
rbalamohan opened this issue Mar 8, 2018 · 1 comment
Closed

Consider using Murmur3 instead of SHA in VariationOrRollout #120

rbalamohan opened this issue Mar 8, 2018 · 1 comment

Comments

@rbalamohan
Copy link

https://github.com/launchdarkly/java-client/blob/master/src/main/java/com/launchdarkly/client/VariationOrRollout.java#L51

VariationOrRollout is one of the hotpath code and it internally uses SHA1 for computing hash. SHA1 is CPU intensive and is outdated as well. It would be good to consider using other hashing functions like murmur3 which is fairly CPU optimised. Guava libraries should have murmur3 IIRC.

@eli-darkly
Copy link
Contributor

See PR comments. Summary: we're considering such a change, but it would require server-side changes first. I'm closing this issue since it's not something we can address in the Java SDK by itself, but we're still tracking it as a desirable future feature.

eli-darkly added a commit that referenced this issue Mar 21, 2019
bump eventsource version so we're no longer getting JSR305 annotations
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants