Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in https://github.com/launchdarkly/java-server-sdk/blob/master/src/main/java/com/launchdarkly/sdk/server/EventBroadcasterImpl.java#L93 #211

Closed
andrewwilsonnew opened this issue Sep 17, 2020 · 2 comments

Comments

@andrewwilsonnew
Copy link

Is this a support request?
No

Describe the bug
Typo in https://github.com/launchdarkly/java-server-sdk/blob/master/src/main/java/com/launchdarkly/sdk/server/EventBroadcasterImpl.java#L93

Currently reads :
Loggers.MAIN.warn("Unexpected error from listener ({0}): {1}", l.getClass(), e.toString());

Should read:
Loggers.MAIN.warn("Unexpected error from listener ({}): {}", l.getClass(), e.toString());

To reproduce
Generate an exception from the listener

Expected behavior
The message should be correctly logged

Logs
[LaunchDarkly-tasks-0] WARN com.launchdarkly.sdk.server.LDClient - Unexpected error from listener ({0}): {1}

SDK version
5.0.3

Language version, developer tools
Java

OS/platform
Mac

Additional context
I think this is just a clear typo and should be fixed.

@gwhelanLD
Copy link
Contributor

Hi @andrewwilsonnew,

Thanks for the report, I've filed it internally (ch89935). We'll include this change in the next patch release.

Thanks!
@gwhelanLD

LaunchDarklyCI pushed a commit that referenced this issue Sep 28, 2020
Java SDK should only log exception stacktraces at debug level
@eli-darkly
Copy link
Contributor

Fixed in the 5.1.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants