Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #162 #163

Merged
merged 1 commit into from May 20, 2019
Merged

Fixes #162 #163

merged 1 commit into from May 20, 2019

Conversation

kutsal
Copy link
Contributor

@kutsal kutsal commented May 20, 2019

Fix Builder to set the right field for userKeysFlushInterval

@kutsal kutsal mentioned this pull request May 20, 2019
Closed
eli-darkly
eli-darkly approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@eli-darkly eli-darkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eli-darkly eli-darkly merged commit 61fdf7e into launchdarkly:master May 20, 2019
@bwoskow-ld bwoskow-ld mentioned this pull request May 21, 2019
Merged
LaunchDarklyCI pushed a commit that referenced this pull request Jan 6, 2020
@eli-darkly
Merge pull request #163 from launchdarkly/eb/ch43307/test-bucketing
173f411 
add unit tests for basic bucketing logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eli-darkly eli-darkly eli-darkly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kutsal @eli-darkly