This repository has been archived by the owner on May 30, 2024. It is now read-only.
Thread-local methods for setting user #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably need to explicitly document the potential limitations of this approach-- the main one being that any work done in a new thread will lose the user context. |
|
lgtm |
|
I've been thinking that this is unnecessary magic. Declining. |
drichelson
added a commit
that referenced
this pull request
Apr 11, 2017
Add proxy authentication support
eli-darkly
added a commit
that referenced
this pull request
Apr 30, 2020
(5.0 - #4) remove a lot of deprecated stuff
eli-darkly
added a commit
that referenced
this pull request
Apr 30, 2020
(5.0 - #4) implement flag change events
eli-darkly
added a commit
that referenced
this pull request
May 14, 2020
…ates-intf-1 (#4) rename DataStoreUpdates to DataSourceUpdates
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Jun 2, 2020
(5.0 - #4) add test coverage reporting
LaunchDarklyReleaseBot
pushed a commit
that referenced
this pull request
Dec 7, 2022
…-context (#4) simplify usage of ClientContext with component factories, remove BasicConfiguration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it may be inconvenient to set the user context at the same time as the feature flag request is made. This approach allows developers to set the user context wherever it's convenient, and then request feature flags without having to pass in a user each time.