Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 - 'Promise' is undefined #106

Closed
theonesuperdave opened this issue Aug 10, 2018 · 2 comments
Closed

IE11 - 'Promise' is undefined #106

theonesuperdave opened this issue Aug 10, 2018 · 2 comments

Comments

@theonesuperdave
Copy link

I have the LD client running perfectly in my SPA, except that Internet Explorer 11 doesn't like the ES6 Promise usage which is unsupported. Promise is still being used in the ldclient.min.js file; everything works fine in Chrome and Edge browsers.

[object Error]{description: "'Promise' i...", innerError: undefined, message: "'Promise' i...", name: "ReferenceEr...", number: -2146823279, stack: "ReferenceEr..."}

Looks like it's complaining about EventSender.js (54,9) but I found Promise used in other modules as well.

After looking at the docs, I wasn't able to find any guidance for this one, so please advise when you can.

@apucacao
Copy link
Contributor

Hi @theonesuperdave,

We currently recommend using a polyfill like es6-promise to support Promise in older browsers.

Apologies for the lack of guidance there — we're going to update the README and docs now.

@theonesuperdave
Copy link
Author

OK. Thanks, @apucacao. I'm already looking at that polyfill now. I noticed other non-compliant IE11 items (const, for example) were removed from the minified file, and thought maybe I had missed something in the docs..

eli-darkly added a commit that referenced this issue Dec 7, 2018
initial restructuring of project to use Lerna
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants