Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build system to use rollup #52

Closed
tdeekens opened this issue Nov 5, 2017 · 5 comments
Closed

Refactor build system to use rollup #52

tdeekens opened this issue Nov 5, 2017 · 5 comments

Comments

@tdeekens
Copy link

tdeekens commented Nov 5, 2017

The current build system seems to be around webpack. However, generally rollup works a bit better for libraries whereas webpack works super nice with applications.

Would there be interest in moving the build system to rollup? Another option then would also be to refactor all code to ES6 code while building UMD, ESM and CJS bundles.

I've done such thing quite a few times now and could offer my help just wanted to clarify first if that brings up interest.

@tdeekens
Copy link
Author

Due to lack of interest from the repositories owners I will close this.

@apucacao
Copy link
Contributor

Hi @tdeekens

Sorry about that! We missed this one.

We do favor anything that makes it easier for developers to use our SDK. So I'm curious to hear more about this.

I'm not very familiar with Rollup. At a glance, it seems like the SDK would also be (written and) usable as an ES6 module, in addition to UMD, ESM and CJS modules. Would updating to Webpack 2 achieve the same thing?

@apucacao apucacao reopened this Nov 14, 2017
@tdeekens
Copy link
Author

You can achieve the same thing using webpack@2. However, it's generally kind of true that webpack is for apps and rollup for libraries. It's just a bit simpler to configure and doesn't come with loads of features libraries won't need (e.g. code splitting).

@tdeekens
Copy link
Author

So how would you like to go about this? What would be a preferred way? Should I open a PR removing webpack for rollup trying to show some benefits in using it?

@apucacao
Copy link
Contributor

That would be great, thanks!

eli-darkly added a commit that referenced this issue May 26, 2018
summary events (1.5): deprecate snake-cased option names, add camelcased equivalents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants