-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Vercel 1.0.0 #177
feat: Vercel 1.0.0 #177
Conversation
@monsagri Have you followed the initial package publish steps here? You can also use the cloudflare initial release PR for reference. |
Thanks for the pointers, I've updated to follow that process! |
It's possible. We can try. |
The problem with "release-as" in a commit message is that if affects all packages that have changes next time they release. It is really not for a monorepo. |
packages/sdk/vercel/package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@launchdarkly/vercel-server-sdk", | |||
"version": "0.4.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be very careful manually updating these. It should be ok as long as there are release notes. Release please has problems if it doesn't make any changes in a project when it releases it. Because then it cannot find the release PR associated with the project.
So, generally you always have a change because it updates the version and changes there changelog. So make sure at least one of those will still be true.
release-please-config.json
Outdated
@@ -14,7 +14,8 @@ | |||
"extra-files": [ | |||
"src/createPlatformInfo.ts" | |||
], | |||
"bump-minor-pre-major": true | |||
"bump-minor-pre-major": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.0.0 will be "major" so you can remove "bump-minor-pre-major" it just served to stop it going 1.0.0 automatically. (If you removed it, and had feat changes, then it would update to 1.0.0 on its own).
Thanks, I totally missed that! |
c9a0f76
to
5506cde
Compare
Do you have a beta notice you can remove? This PR isn't going to make a release. There aren't any releasable units for the SDK. |
Explanation of releasable units: https://launchdarkly.atlassian.net/wiki/spaces/PD/pages/2425487795/Conventional+Commits+with+Release-Please I would at least change the commit message of this PR, when you merge it, to "feat: Vercel 1.0.0" or something like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving. I changed the PR title to something releasable. This contains changes in your example repo, so it will release them.
Note, I think I mentioned this before, but examples are not going to get automatic version bumps, which may be inconvenient later. It is fine for this release though.
Thanks, that's really helpful! |
🤖 I have created a release *beep* *boop* --- <details><summary>vercel-server-sdk: 1.0.0</summary> ## [1.0.0](vercel-server-sdk-v0.4.4...vercel-server-sdk-v1.0.0) (2023-06-28) ### Features * Vercel 1.0.0 ([#177](#177)) ([78daeaf](78daeaf)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Intending to use release-now to release 1.0.0 for GA today, judging from their docs having that message above in the merge commit should do it?