[sc-157321] Allow designating dir in github action
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #157321: github action should allow |
jazanne
commented
Nov 9, 2022
Comment on lines
27
to
29
| dir: | ||
| description: "Path to existing checkout of the repository. You may use this if your action checkouts multiple repositories. The default value is `$GITHUB_WORKSPACE`." | ||
| required: false |
There was a problem hiding this comment.
we don't set an explicit default sting here, because it reads the default from environment variable $GITHUB_WORKSPACE
mmrj
approved these changes
Nov 9, 2022
jazanne
force-pushed
the
jwhite/sc-157321/github-action-should-allow-dir-to-be-specified
branch
from
8fdabc6
to
bf6a0a9
Compare
|
@mmrj i had to change how this works, sorry to make ya re-review! |
|
@InTheCloudDan wasn't sure how to test this since, if you have thoughts i'd love to hear them. |
|
@jazanne yeah this is an interesting one, I'm not really sure what would be the best way to it. Maybe just a single unit test confirming what's set is correctly passed in?? |
mmrj
requested changes
Nov 9, 2022
InTheCloudDan
approved these changes
Nov 14, 2022
jazanne
deleted the
jwhite/sc-157321/github-action-should-allow-dir-to-be-specified
branch
jazanne
restored the
jwhite/sc-157321/github-action-should-allow-dir-to-be-specified
branch
Co-authored-by: Molly <molly.jones@launchdarkly.com>
Co-authored-by: Molly <molly.jones@launchdarkly.com>
jazanne
force-pushed
the
jwhite/sc-157321/github-action-should-allow-dir-to-be-specified
branch
from
13303a4
to
05e66d4
Compare
annabkr
approved these changes
Dec 4, 2023
mmrj
approved these changes
Dec 4, 2023
|
not high priority |
jazanne
deleted the
jwhite/sc-157321/github-action-should-allow-dir-to-be-specified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is completely optional, but is useful if someone checks out multiple repos in their action.
For example, this git-gatsby workflow used to check out multiple repos internal repos
--
Dev notes
this must use
envoverride and not github action input because of how env variable is used to find the configuration file etc.