Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onClose or onReadyStateChange event #12

Closed
ShaneMcC opened this issue Jan 18, 2017 · 3 comments · Fixed by #16
Closed

Add onClose or onReadyStateChange event #12

ShaneMcC opened this issue Jan 18, 2017 · 3 comments · Fixed by #16

Comments

@ShaneMcC
Copy link
Contributor

ShaneMcC commented Jan 18, 2017

Would be useful to be able to detect when disconnects or reconnects happen.

@ShaneMcC
Copy link
Contributor Author

As an addition to this (maybe a separate issue?) it would be nice to be able to provide a new URL to reconnect to.

(Use case: I'm using this library to interact with SignalR end points, and after disconnecting, the reconnect needs to pass a slightly-different URI to verify group membership top ensure the new connection continues to get the events it should)

@jkodumal
Copy link
Contributor

Interesting use case-- sounds like a separate issue. It's not something that we've thought of, since it's not really part of the SSE standard, but if I remember correctly SignalR kind of deviates from that in places.

Would you be interested in contributing that functionality?

@ShaneMcC
Copy link
Contributor Author

Thanks - I'll break that out as a separate issue - wasn't sure if you had a specific reason for ensuring the URI didn't change.

Happy to look to contribute the code myself, was just logging the issues first :)

This was referenced Jan 19, 2017
pkaeding added a commit that referenced this issue Jan 17, 2018
…methods

added support for arbitrary HTTP methods & request body in event sour…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants