chore: Add GH action and release please support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
approved these changes
Apr 26, 2024
| contents: write | ||
| uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v1.10.0 | ||
| with: | ||
| base64-subjects: "${{ needs.build-publish.outputs.package-hashes }}" |
There was a problem hiding this comment.
Curious why this is quoted? is it an array or something interesting?
There was a problem hiding this comment.
I'm not sure. Rouel did the original provenance work. I've just been applying his templates to my other repos. My guess is just protecting from some weird characters or just being overly cautious.
| upload-tag-name: ${{ steps.release.outputs.tag_name }} | ||
| package-hashes: ${{ steps.build.outputs.package-hashes}} | ||
| steps: | ||
| - uses: google-github-actions/release-please-action@v3 |
There was a problem hiding this comment.
Maybe. Ryan had a similar question on the ruby otel branch. I'm just keeping my repos all using the same version of release please for now, and then I'll go through and update them in mass. This way it's a one and done thing. It also let's this be a copy-paste job, so I'm confident the first release will work.
keelerm84
force-pushed
the
mk/sc-241885/support-documents
branch
from
571f137
to
537819e
Compare
keelerm84
force-pushed
the
mk/sc-241885/gh-actions
branch
2 times, most recently
from
08cea4b
to
269715f
Compare
keelerm84
force-pushed
the
mk/sc-241885/gh-actions
branch
from
269715f
to
1b32912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.