-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add GH action and release please support #4
Conversation
contents: write | ||
uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v1.10.0 | ||
with: | ||
base64-subjects: "${{ needs.build-publish.outputs.package-hashes }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this is quoted? is it an array or something interesting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Rouel did the original provenance work. I've just been applying his templates to my other repos. My guess is just protecting from some weird characters or just being overly cautious.
upload-tag-name: ${{ steps.release.outputs.tag_name }} | ||
package-hashes: ${{ steps.build.outputs.package-hashes}} | ||
steps: | ||
- uses: google-github-actions/release-please-action@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would using @v4 work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. Ryan had a similar question on the ruby otel branch. I'm just keeping my repos all using the same version of release please for now, and then I'll go through and update them in mass. This way it's a one and done thing. It also let's this be a copy-paste job, so I'm confident the first release will work.
571f137
to
537819e
Compare
08cea4b
to
269715f
Compare
269715f
to
1b32912
Compare
No description provided.