Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestData.__call__ does not line up with Config.__update_processor_class #273

Closed
csapuntz opened this issue Mar 5, 2024 · 2 comments · Fixed by #274 or #275
Closed

TestData.__call__ does not line up with Config.__update_processor_class #273

csapuntz opened this issue Mar 5, 2024 · 2 comments · Fixed by #274 or #275

Comments

@csapuntz
Copy link

csapuntz commented Mar 5, 2024

Describe the bug

Sample code in TestData says to:

   td = TestData.data_source()
   client = LDClient(config=Config('SDK_KEY', update_processor_class = td))

However
update_processor_class: Optional[Callable[[str, 'Config', FeatureStore], UpdateProcessor]

and TestData.__call__ is:

def __call__(self, config, store, ready):

To reproduce
Set up pylance in Visual Studio and see the type errors when you try the sample code.

Expected behavior
No type errors, compatible function signatures.

Logs
N/A

SDK version
launchdarkly-server-sdk 9.2.1

Language version, developer tools
Python 3.9

OS/platform
Ubuntu 20.04

@keelerm84
Copy link
Member

Thank you for filing this issue with us. I will look into it and let you know once we have a resolution.

keelerm84 pushed a commit that referenced this issue Mar 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[9.2.2](9.2.1...9.2.2)
(2024-03-07)


### Bug Fixes

* Correct typehint on Config.update_processor_class
([#274](#274))
([d386f9c](d386f9c)),
closes
[#273](#273)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@keelerm84
Copy link
Member

Fixed in 9.2.2

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants