fix: Move tests under ldclient namespace (#29) #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #239226: Deal with test package collision. |
keelerm84
force-pushed
the
mk/sc-239231/fix-build
branch
4 times, most recently
from
e26c863
to
1d58c87
Compare
Previous distributions of this package included two packages -- ldclient and testing. This top level testing namespace can conflict with other packages. In fact, it conflicts with our own eventsource library. In general this doesn't matter, but it may if: 1. You are using a build process that warns about conflicts (see [this issue][1]) 2. You want to install the sdist on an unsupported platform and would like to be able to verify the tests. To resolve this issue, we are moving the testing folder into the ldclient package. These testing files will only be included in the sdist format. This allows for a smaller wheel size while also allowing for flexibility with consumers. [1]: #281
keelerm84
force-pushed
the
mk/sc-239226/fix-python-packaging
branch
from
5dccb43
to
6a71a0a
Compare
louis-launchdarkly
approved these changes
Apr 4, 2024
keelerm84
pushed a commit
that referenced
this pull request
Apr 5, 2024
🤖 I have created a release *beep* *boop* --- ## [9.3.1](9.3.0...9.3.1) (2024-04-04) ### Bug Fixes * Move tests under ldclient namespace ([#29](#29)) ([#283](#283)) ([c7d367a](c7d367a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous distributions of this package included two packages -- ldclient and testing. This top level testing namespace can conflict with other packages. In fact, it conflicts with our own eventsource library.
In general this doesn't matter, but it may if:
To resolve this issue, we are moving the testing folder into the ldclient package. These testing files will only be included in the sdist format. This allows for a smaller wheel size while also allowing for flexibility with consumers.