Use expiringdict from PyPI #29
Comments
|
No-- we should grab it from PyPi |
|
I noticed that the latest PyPI version of ExpringDict doesn't have the mailgun/expiringdict@62c50ce patch so therefore doesn't support Python 3 correctly. Our local copy does so we have to wait for @mailgun to upload a new ExpiringDict package. I added a comment about this issue to our local copy (72b770f#diff-a6272bf675feff281629b112d50a38b2). |
|
Good catch, thanks! On Fri, Nov 6, 2015 at 3:25 PM, Albert Wang notifications@github.com
|
Previous distributions of this package included two packages -- ldclient and testing. This top level testing namespace can conflict with other packages. In fact, it conflicts with our own eventsource library. In general this doesn't matter, but it may if: 1. You are using a build process that warns about conflicts (see [this issue][1]) 2. You want to install the sdist on an unsupported platform and would like to be able to verify the tests. To resolve this issue, we are moving the testing folder into the ldclient package. These testing files will only be included in the sdist format. This allows for a smaller wheel size while also allowing for flexibility with consumers. [1]: #281
Previous distributions of this package included two packages -- ldclient and testing. This top level testing namespace can conflict with other packages. In fact, it conflicts with our own eventsource library. In general this doesn't matter, but it may if: 1. You are using a build process that warns about conflicts (see [this issue][1]) 2. You want to install the sdist on an unsupported platform and would like to be able to verify the tests. To resolve this issue, we are moving the testing folder into the ldclient package. These testing files will only be included in the sdist format. This allows for a smaller wheel size while also allowing for flexibility with consumers. [1]: #281
Previous distributions of this package included two packages -- ldclient and testing. This top level testing namespace can conflict with other packages. In fact, it conflicts with our own eventsource library. In general this doesn't matter, but it may if: 1. You are using a build process that warns about conflicts (see [this issue][1]) 2. You want to install the sdist on an unsupported platform and would like to be able to verify the tests. To resolve this issue, we are moving the testing folder into the ldclient package. These testing files will only be included in the sdist format. This allows for a smaller wheel size while also allowing for flexibility with consumers. [1]: #281
🤖 I have created a release *beep* *boop* --- ## [9.3.1](9.3.0...9.3.1) (2024-04-04) ### Bug Fixes * Move tests under ldclient namespace ([#29](#29)) ([#283](#283)) ([c7d367a](c7d367a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I notice that a full copy of the ExpiringDict file is at https://github.com/launchdarkly/python-client/blob/4cf65590c0523fe22641d60bf655214e061be3e2/ldclient/expiringdict.py with the only difference being line 17. Is there a reason why ExpringDict isn't being imported as a package from PyPI instead? IANL, but I assumed that the NOTICE.txt would be sufficient to cover attribution requirements of the apache license.
The text was updated successfully, but these errors were encountered: