feat: Add wait_for_initialization with timeout parameter #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sc-243032/timeout
branch
from
8fb217e
to
c0a932e
Compare
louis-launchdarkly
approved these changes
May 10, 2024
keelerm84
force-pushed
the
mk/sc-243032/timeout
branch
from
c0a932e
to
43d24e4
Compare
cwaldren-ld
reviewed
May 17, 2024
Comment on lines
290
to
292
| // We need o try initialized_async and also start a timer that figures after timeout. | ||
| // If the timer figures, I want to return None. Otherwise, we should return the result of | ||
| // initialized_async. |
cwaldren-ld
approved these changes
May 17, 2024
keelerm84
force-pushed
the
mk/sc-243032/timeout
branch
from
72f5883
to
6dda404
Compare
This method serves as a replacement for the `initialized_async` method, which has now been deprecated. LaunchDarkly does not recommend blocking an application indefinitely, and so we are working to remove methods that suggest this behavior.
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
keelerm84
force-pushed
the
mk/sc-243032/timeout
branch
from
6dda404
to
7bd1375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method serves as a replacement for the
initialized_asyncmethod, which has now been deprecated. LaunchDarkly does not recommend blocking an application indefinitely, and so we are working to remove methods that suggest this behavior.