Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix how we find num replicas for endpoints and collectors #340

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

boetro
Copy link
Collaborator

@boetro boetro commented Dec 21, 2023

No description provided.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5e959fe) 74.65% compared to head (03d3ed3) 74.65%.

Files Patch % Lines
...tors/collector_pattern/receive_process_push_ack.py 0.00% 1 Missing ⚠️
...actors/endpoint_pattern/receive_process_respond.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   74.65%   74.65%           
=======================================
  Files         168      168           
  Lines        7561     7561           
=======================================
  Hits         5645     5645           
  Misses       1916     1916           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boetro boetro merged commit a899c7b into launchflow:main Dec 22, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants