You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This was discovered when we tried to use an RPM of less than zero...
In DRV8880.x RPM it's a short, but in BasicStepperDriver.x it's a float...
Changing casting on DRV8880.x from short to float fixes this issue...
This bug may be in other drivers.... (looks like other drivers do not re-define begin(), also the prototypes are most likely not needed in the driver as they are defined in: BasicStepperDriver.h)
In DRV8880.h
53 void begin(short rpm=60, short microsteps=1);
In DRV8800.cpp
42 void DRV8880::begin(short rpm, short microsteps){
BasicStepperDriver::begin(rpm, microsteps);
setCurrent(100);
}
In BasicStepperDriver.h
118 void begin(float rpm=60, short microsteps=1);
In BasicStepperDriver.cpp
41 void BasicStepperDriver::begin(float rpm, short microsteps){
The text was updated successfully, but these errors were encountered:
This was discovered when we tried to use an RPM of less than zero...
In DRV8880.x RPM it's a short, but in BasicStepperDriver.x it's a float...
Changing casting on DRV8880.x from short to float fixes this issue...
This bug may be in other drivers.... (looks like other drivers do not re-define begin(), also the prototypes are most likely not needed in the driver as they are defined in: BasicStepperDriver.h)
In DRV8880.h
In DRV8800.cpp
In BasicStepperDriver.h
In BasicStepperDriver.cpp
The text was updated successfully, but these errors were encountered: