Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Supported URLs containing special characters not opening in Sync #839

Closed
henkka-fi opened this issue Mar 21, 2022 · 4 comments
Closed
Labels
bug Something isn't working details neeed

Comments

@henkka-fi
Copy link

henkka-fi commented Mar 21, 2022

Describe the bug
When opening supported URLs containing special characters (e.g. Nordic ÄÖÅ), Sync link handler does not recognize the URL and the URL will not open in Sync.

To Reproduce

  1. Open any Android app
  2. Click on supported, e.g. reddit.com, URL containing special characters
  3. The URL opens in browser, not in Sync. The issue can also be reproduced in e.g. long pressing the URL in any app and Sync link handler will not show up as option in the menu at all.

Expected behavior

Sync link handler recognizes the supported URL correctly and opens it in Sync.

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S20 FE
  • OS: Android 11
  • Browser: Any
  • Version: 22.3.20 (beta)
@henkka-fi henkka-fi added the bug Something isn't working label Mar 21, 2022
@laurencedawson
Copy link
Owner

Example? Cheers

@henkka-fi
Copy link
Author

henkka-fi commented Mar 27, 2022

Couple of example URLs:

https://www.reddit.com/r/Suomi/comments/tdc639/venäjän_hyökkäys_ukrainaan_megaketju/
https://www.reddit.com/r/sweden/comments/tijjzk/ukrainakriget_megatråd_v/

Also tried to open them on Android 12 with Sync beta v22.3.24 and it behaves similarly (opening in browser).

@bohrabhijeet
Copy link
Collaborator

bohrabhijeet commented Jun 3, 2022

Also tried to open them on Android 12 with Sync beta v22.3.24 and it behaves similarly (opening in browser).

I'm on Sync v22.06.02 at the moment. These two links open just fine. Can you check again, please?

@laurencedawson laurencedawson added this to the Solid as a rock milestone Jun 8, 2022
@laurencedawson
Copy link
Owner

Added support for diacritics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working details neeed
Projects
None yet
Development

No branches or pull requests

3 participants