-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
32 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0e3e4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The larger APK size (100 MB) is a result of the upgrade to React Native 0.74.
According to the React Native team, despite the larger APK size, the app should take less space on-device. See facebook/react-native#44291 (comment) for details.
If we need to revert this, adding extractNativeLibs="true" reduces the APK size back to the previous 45 MB. However, according to the React Native team, it makes the app slower. According to the Android documentation,
extractNativeLibs
has different default values depending on theminSdkVersion
. React Native 0.74 increased theminSdkVersion
, which may have changed the default value ofextractNativeLibs
.For future reference, this diff would set
extractNativeLibs
to true, resulting in a 45 MB APK.If necessary, we can also decrease the APK size even further.
It's also possible to get the generated APK down to 40.7 MB by — in addition to setting
extractNativeLibs
to true — enabling code and resource minification.Without the `extractNativeLibs="true", the APK size is still roughly 94 MB.
a0e3e4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mentioning @IzzySoft because of the APK size requirements described in #8710.
a0e3e4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @personalizedrefrigerator – that will indeed be a problem. I can make exceptions when the size limit is slightly exceeded – but 100 MB is 3 times above it, that's too much. Is that per-ABI, or the "fat build" only? If the latter, what will be the size for per-ABI builds then? That's what the updater here currently picks.
And PS, there was no Android release since 11/2022: https://github.com/laurent22/joplin-android/releases
a0e3e4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the build that includes all ABIs since we don't have separate builds anymore. As mentioned in the other threads, the package size in most cases is not too important, for example because it's going to be gzipped when downloaded and that will be around 45 MB. Could that help in your particular situation?
We publish an Android release every time but GitHub broke sorting of releases a while back and as I understand it's a "won't fix". You'll find the most recent releases after page 6. But to view the releases in the correct order you can go to the Tags tab instead.
a0e3e4f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for the IzzyOnDroid repo, sorry.
Ah! Now that you mention it I remember, we've talked about that in the past (and meanwhile I found at least 3 or 4 other projects with the same issue). I just see all tags are from 2020-08-08 in the tag list, while the date is correct when opening the tag, yay. So the IoD updater just fetched none of the newer releases as
ApkMatch: /32bit\.apk$/i
found no matches anymore… What shall we do with the IoD listing then, @laurent22?