Skip to content

Commit

Permalink
Electron: Fixes #3: Paths with '.' would cause JSX compilation to fail
Browse files Browse the repository at this point in the history
  • Loading branch information
laurent22 committed Dec 10, 2017
1 parent 043be19 commit a59bf55
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
17 changes: 11 additions & 6 deletions BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,17 @@ From `/ElectronClient` you can also run `run.sh` to run the app for testing.

# Building the Mobile application

From `/ReactNativeClient`, run `npm install`, then `react-native run-ios` or `react-native run-android`.
First you need to to setup React Native to build projects with native code. For this, follow the instructions on the [Get Started](https://facebook.github.io/react-native/docs/getting-started.html) tutorial, in the "Building Projects with Native Code" tab.

Then, from `/ReactNativeClient`, run `npm install`, then `react-native run-ios` or `react-native run-android`.

# Building the Terminal application

From `/CliClient`:
- Run `npm install`
- Then `build.sh`
- Copy the translations to the build directory: `rsync -aP ../ReactNativeClient/locales/ build/locales/`
- Run `run.sh` to start the application for testing.
```
cd CliClient
npm install
./build.sh
rsync -aP ../ReactNativeClient/locales/ build/locales/
```

Run `run.sh` to start the application for testing.
2 changes: 1 addition & 1 deletion ElectronClient/app/compile-jsx.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ fs.readdirSync(guiPath).forEach((filename) => {
if (ext !== 'jsx') return;
p.pop();

const basePath = p.join('/');
const basePath = p.join('.');

const jsPath = basePath + '.min.js';

Expand Down

0 comments on commit a59bf55

Please sign in to comment.