Desktop: Resolves #9984: Allow 'All Notes' to have 'Toggle own sort order' #10021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bar - Fixed the issue laurent22#7834 - added "spellCheckerMenu.test.ts" to test the changes and the expected behavior: all passed! - added jest.mock in "jest.setup.js" to mock the Menu from @electron/remote. - modified "buildScriptIndexes" to ignore ".test.ts" files so it does not include them in index.ts. That caused some issues with duplicate identifiers and more errors.
- Test case passed: ['en-GB', 'en-US', 'en-CA', 'es-ES', 'es-MX'] -> 'en, es'
- manually tested locally and the changes work!
- major change: added the 'All Notes' folder when initializing the app and implemented the 'folderExists' to prevent adding the 'All Notes' again.
|
Something's wrong here, only 1 check and merge conflicts with my already merged commits |
laurent22
reviewed
Feb 28, 2024
…t fails the Github Action - Not sure why I got this merge conflict
…est.ts to be the same as before
|
@PackElend label me please |
…u for 'All Notes'
laurent22
reviewed
Mar 5, 2024
laurent22
reviewed
Mar 9, 2024
packages/app-desktop/services/sortOrder/PerFolderSortOrderService.ts
Outdated
Show resolved
Hide resolved
laurent22
reviewed
Mar 11, 2024
laurent22
reviewed
Mar 14, 2024
Comment on lines
476
to
477
| folderItem_click(ALL_NOTES_FILTER_ID); | ||
| }; |
There was a problem hiding this comment.
While we're at it, would you mind making this onAllNotesClick_ handler use useCallback too? It would have folderItem_click and props.dispatch as dependencies
There was a problem hiding this comment.
I don't mind at all, I'll do it!
|
Looks good now, thanks @HahaBill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduction from the Joplin Forum: https://discourse.joplinapp.org/t/introducing-hahabill/36075/3
The user can 'Toggle own sort order' for 'All notes', this is demonstrated in the video below.
✨ Fixes: #9984
Testing and Verification Process
1. To ensure the changes are working as expected:
Screen.Recording.2024-02-28.at.17.14.01.mov
2. Testing:
If more tests are needed, let me know!
Notes
I noticed that you are not able to custom ordering with 'All Notes', not sure if this behavior is desired or not:
Screen.Recording.2024-02-28.at.18.05.52.mov
Checklist: