Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Resolves #9984: Allow 'All Notes' to have 'Toggle own sort order' #10021

Merged
merged 30 commits into from Mar 16, 2024
Merged

Desktop: Resolves #9984: Allow 'All Notes' to have 'Toggle own sort order' #10021

merged 30 commits into from Mar 16, 2024

Commits on Feb 22, 2024

  1. Desktop: Made the same spellcheck languages more specific in the titl… 

    …e bar

- Fixed the issue laurent22#7834

- added "spellCheckerMenu.test.ts" to test the changes and the expected behavior: all passed!

- added jest.mock in "jest.setup.js" to mock the Menu from @electron/remote.

-  modified "buildScriptIndexes" to ignore ".test.ts" files so it does not include them in index.ts. That caused some issues with duplicate identifiers and more errors.
    @HahaBill
    HahaBill committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b07903c View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'laurent22:dev' into dev

    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d1e3652 View commit details
    Browse the repository at this point in the history

  2. Fixed the build issue from GitHub Actions

    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9f2b42e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' of https://github.com/HahaBill/joplin-hahabill int… 

    …o dev
    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7f2c5d4 View commit details
    Browse the repository at this point in the history

  4. Create determineProfileDir.js

    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a831916 View commit details
    Browse the repository at this point in the history

  5. Desktop: Putting the mock back into the test file "showSpellCheckerMe… 

    …nu.test.ts"
    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8a936d6 View commit details
    Browse the repository at this point in the history

  6. Desktop: Implemented 2nd solution and modified unit test 

    - Test case passed: ['en-GB', 'en-US', 'en-CA', 'es-ES', 'es-MX'] -> 'en, es'
    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e934d91 View commit details
    Browse the repository at this point in the history

  7. Deleting an auto-generated file: determineProfileDir.js

    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    12ba64f View commit details
    Browse the repository at this point in the history

  8. Desktop: More clarity on changes in "buildScriptIndexes.js" 

    - manually tested locally and the changes work!
    @HahaBill
    HahaBill committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d4b6926 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Desktop: Allow 'Toggle own sort order' for 'All Notes' 

    - major change: added the 'All Notes' folder when initializing the app and implemented the 'folderExists' to prevent adding the 'All Notes' again.
    @HahaBill
    HahaBill committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    596c7f4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev

    @HahaBill
    HahaBill committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    69b1a77 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Desktop: Going for the virtual folder solution

    @HahaBill
    HahaBill committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c5ffc07 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Desktop: Refactoring a test in showSpellCheckerMenu.test.ts because i… 

    …t fails the Github Action

- Not sure why I got this merge conflict
    @HahaBill
    HahaBill committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    10b8a32 View commit details
    Browse the repository at this point in the history

  2. Desktop: Only removing or adding new lines for Folder.ts and Folder.t… 

    …est.ts to be the same as before
    @HahaBill
    HahaBill committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d4b6142 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Desktop: Improved solution and removing redundant code

    @HahaBill
    HahaBill committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5581891 View commit details
    Browse the repository at this point in the history

  2. Desktop: removing more redundant code

    @HahaBill
    HahaBill committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c9b72ab View commit details
    Browse the repository at this point in the history

  3. Desktop: Removing an empty line in PerFolderSortOrderService.test.ts

    @HahaBill
    HahaBill committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    f4316d1 View commit details
    Browse the repository at this point in the history

  4. Desktop: Better naming for 'Toggle own sort order' in the context men… 

    …u for 'All Notes'
    @HahaBill
    HahaBill committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6b4a826 View commit details
    Browse the repository at this point in the history

  5. Desktop: Updating 'All Notes' id

    @HahaBill
    HahaBill committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    713a311 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Desktop: Refactored 'itemContextMenu' and removed 'toggleAllNotesCont… 

    …extMenu'
    @HahaBill
    HahaBill committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    47a5783 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into dev

    @HahaBill
    HahaBill committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    36075d9 View commit details
    Browse the repository at this point in the history

  3. Desktop: Fixing merge conflict

    @HahaBill
    HahaBill committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    ca58f76 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Desktop: Refactored 'toggleAllNotesContextMenu'

    @HahaBill
    HahaBill committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    2f5d65e View commit details
    Browse the repository at this point in the history

  2. Desktop: Minor fixes in itemContextMenu and invoking `onAllNotesCli… 

    …ck_()`
    @HahaBill
    HahaBill committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    0c3e6d8 View commit details
    Browse the repository at this point in the history

  3. Desktop: Solved a bug with when clicking 'All Notes' for not staying … 

    …highlighted
    @HahaBill
    HahaBill committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    b32b12c View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Merge branch 'laurent22:dev' into dev

    @HahaBill
    HahaBill committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d76b779 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Merge branch 'dev' into dev

    @laurent22
    laurent22 committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    f460dcd View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Desktop: updated to ALL_NOTES_FILTER_ID and using `folderItem_click… 

    …` function
    @HahaBill
    HahaBill committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    bb2c47a View commit details
    Browse the repository at this point in the history

  2. Desktop: Using useCallback

    @HahaBill
    HahaBill committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    27b7501 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Desktop: Add useCallback to onAllNotesClick_

    @HahaBill
    HahaBill committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    73bdbe8 View commit details
    Browse the repository at this point in the history